Change the definition of MALLOC_ALIGN_MASK so it should always be correct on all platforms. #58495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
compnerd,
jckarter,
mikeash,
kubamracek,
atrick and
Catfish-Man
|
@swift-ci please test |
mikeash
requested changes
Apr 28, 2022
…rect on all platforms.
grynspan
force-pushed
the
jgrynspan/58486-malloc_align_mask
branch
from
77e0798 to
40bc80a
Compare
|
@swift-ci please test |
mikeash
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the definition of
MALLOC_ALIGN_MASKso it should always be correct on all platforms.The default path that defines
MALLOC_ALIGN_MASKdoes so incorrectly, producing a power-of-two value instead of a mask. This change resolves the issue by redefiningMALLOC_ALIGN_MASKfor all platforms in terms of the C/C++ standardmax_align_ttype (which exists for this purpose.)Resolves #58486.