[5.7-04182022][IRGen] Restore the old code path for emitting existential type metadata for plain protocol and protocol composition types. #58502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for plain protocol and protocol composition types. These types should always be wrapped in ExistentialType, but there isn't sufficient validation of this throughout the compiler yet. Change the fatal error when the metadata request sees these plain types to an assert and restore the old type metadata emission path for protocol and protocol composition types to avoid crashing in those cases.
|
@swift-ci please test |
DougGregor
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #58485
ExistentialType, but there isn't sufficient validation of this throughout the compiler yet. Change the fatal error when the metadata request sees these plain types to anassert, and restore the old type metadata emission path for protocol and protocol composition types to avoid crashing in those cases.llvm_unreachablefor protocol constraint types inEmitTypeMetadataRef.Resolves: rdar://92413116