Proper fix for ObjC async jump to null #58515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
kavon
force-pushed
the
proper-fix-for-jump-to-null
branch
from
8a59d48 to
bd6b3e9
Compare
kavon
changed the title
|
@swift-ci please test |
|
I tried to generalize this late ArgumentScope pop using |
|
macOS failures from this batch: Seems to indicate that the error value for calling async ObjC methods that return a YES/NO based on whether the handler was invoked are returning the wrong value on the error path: |
kavon
force-pushed
the
proper-fix-for-jump-to-null
branch
from
8476f88 to
31a0fc9
Compare
|
@swift-ci please test |
when two objc async functions are composed with each other, i.e., f(g()), then the clean-ups for g() would get emitted at an unexpected time, namely, during the suspension for the call to f(). This means that using a clean-up to emit the executor-hop breadcrumb was incorrect. The hop could appear between a get_async continuation and its matching await_continuation, which is an unsupported nested suspension. This commit fixes that by removing the use of the breadcrumb clean-up in favor of providing that breadcrumb directly to the result plan, so that it may be emitted later on when the result plan sees fit. Fixes rdar://91502776
kavon
force-pushed
the
proper-fix-for-jump-to-null
branch
from
31a0fc9 to
814fb42
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
This was referenced May 3, 2022
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What makes this PR "proper" is that it is not just a revert of the code that caused the regression, but a fix made on top of that.
when two objc async functions are composed with each other,
i.e., f(g()), then the clean-ups for g() would get emitted
at an unexpected time, namely, during the suspension for
the call to f(). This means that using a clean-up to emit
the executor-hop breadcrumb was incorrect. The hop could
appear between a get_async continuation and its matching
await_continuation, which is an unsupported nested suspension.
This commit fixes that by removing the use of the breadcrumb
clean-up in favor of providing that breadcrumb directly to
the result plan, so that it may be emitted later on when the
result plan sees fit.
One nice benefit of this change is that the hops are now
consistently the first instruction in the successor blocks.
Fixes rdar://91502776