Fix #57354: Fix-it for deprecated initializers removes the .init part from self.init
#58545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
force-pushed
the
fixit_deprec_self_init
branch
from
7f33b3b to
9f1cf08
Compare
cbjeukendrup
force-pushed
the
fixit_deprec_self_init
branch
from
9f1cf08 to
d8546e8
Compare
….init` part from `self.init`
…nherit the message and renaming from the initializer of the superclass
cbjeukendrup
force-pushed
the
fixit_deprec_self_init
branch
from
d8546e8 to
7f9885b
Compare
|
@cbjeukendrup thank you for your contribution! @xymus and @tshortli know the most about the availability checker; I've tagged them to help review this change |
|
@swift-ci please test |
|
@swift-ci please test macOS |
tshortli
approved these changes
Jan 23, 2023
|
Thanks for reviewing, @tshortli! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the fix-it will only remove the
.initpart if the expr at the left side of the dot is a type, and not, for example, aselfexpr.Resolves: #57354