Skip to content

Use less exotic unicode chars #58617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2022

Conversation

etcwilde
Copy link
Member

@etcwilde etcwilde commented May 2, 2022

The characters used before were in the private-use section had surrogate
chars. This led to issues with some python utf8 decoder implementations
resulting in the error

UnicodeEncodeError: 'utf-8' codec can't encode characters in position
13-20: surrogates not allowed

This uses more normal utf8 characters that should hopefully work
everywhere while still exhibiting issues decoding to ascii.

rdar://92613094

The characters used before were in the private-use section had surrogate
chars. This led to issues with some python utf8 decoder implementations
resulting in the error

```
UnicodeEncodeError: 'utf-8' codec can't encode characters in position
13-20: surrogates not allowed
```

This uses more normal utf8 characters that should hopefully work
everywhere while still exhibiting issues decoding to ascii.
@etcwilde etcwilde requested review from edymtt and bnbarham May 2, 2022 17:21
@etcwilde
Copy link
Member Author

etcwilde commented May 2, 2022

@swift-ci please test

@bnbarham bnbarham merged commit 4b56634 into swiftlang:main May 3, 2022
@etcwilde etcwilde deleted the ewilde/more-normal-utf8-chars branch May 3, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants