[5.7][CSClosure] Mark partially inferred external declarations as invalid #58717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid unnecessary fixes when solver discovers that closure type is only partially resolved after conjunction failure, let's fix it up by replacing type variables with placeholders after solution application. (cherry picked from commit 717db34)
If a syntactic element references an external declaration (relative to its own context), let's check whether it has any type variables, and if so, replace them with errors to remove any possibility of bringing external constraints into element's scope. Resolves: rdar://92347054 (cherry picked from commit 67895c2)
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
hborla
approved these changes
May 7, 2022
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #58493
If a syntactic element references an external declaration (relative
to its own context), let's check whether it has any type variables,
and if so, replace them with errors to remove any possibility of
bringing external constraints into element's scope.
Resolves: rdar://92347054