[NFC][CursorInfo] Temporarily disable some doc comment check lines #58719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request swiftlang/llvm-project#4442 brings in a change to `RawComment::getFormattedText` that removes spurious new lines and whitespaces at the end of block comments. It breaks the `cursor_symbol_graph_objc` test which is assuming the old behavior. Temporarily disable the relevant check lines in the test to merge the llvm change, and then fix the test properly and switch to the new `getFormattedLines` in SymbolGraphGen.
zixu-w
requested review from
bnbarham,
QuietMisdreavus,
ethan-kusters,
franklinsch and
daniel-grumberg
|
There's quite a bit of cherry-picking that will be required at the moment :( TLDR: You'll want this change in |
bnbarham
approved these changes
May 6, 2022
|
@swift-ci Please smoke test |
|
Linux test failed with git clone errors... Trying again |
daniel-grumberg
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request swiftlang/llvm-project#4442 brings in a change to
RawComment::getFormattedTextthat removes spurious new linesand whitespaces at the end of block comments. It breaks the
cursor_symbol_graph_objctest which is assuming the old behavior.Temporarily disable the relevant check lines in the test to merge the
llvm change, and then fix the test properly and switch to the new
getFormattedLinesin SymbolGraphGen.