Clean up IDE member type hack #5876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
When printing a nested type, make sure we call getMemberSubstitutions() with the correct DeclContext.
This workaround is no longer needed now that we always use the correct DeclContext with getMemberSubstitutions().
This fixes a regression from the previous patch which got rid of PrintOptions::StripDynamicSelf. When printing protocol declarations with a BaseType set in PrintOptions, we can end up with a DynamicSelfType wrapping a non-class type, if the protocol requirement returned Self. Note that this changes the diagnostic for missing protocol requirements slightly; we used to sometimes refer to 'Self' even if the conforming type is not a class, which is not accepted by the type checker anyway. I believe the new diagnostics are more correct.
slavapestov
force-pushed
the
clean-up-ide-member-type-hack
branch
from
a7ed54f to
1df6e51
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.