Skip to content

[5.7] RequirementMachine: Disable redundant requirement diagnostics by default #58814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 12, 2022
Merged

[5.7] RequirementMachine: Disable redundant requirement diagnostics by default #58814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9bd0d37
Add test case for rdar://92092635
slavapestov Apr 21, 2022
1677852
Add regression test for rdar://problem/91771352
slavapestov Apr 18, 2022
c6e1556
RequirementMachine: Fix a case where we diagnose requirements made re…
slavapestov May 10, 2022
9c00877
RequirementMachine: Move diagnostics code into a new Diagnostics.cpp
slavapestov May 10, 2022
f2972f0
RequirementMachine: getRequirementForDiagnostics() doesn't need to re…
slavapestov May 10, 2022
3a8daa9
RequirementMachine: Pack the RequirementID field of Rule into a bitfield
slavapestov May 10, 2022
ae51686
RequirementMachine: Update remaining tests for requirement machine di…
slavapestov May 10, 2022
867adbd
RequirementMachine: Turn off redundant requirement warnings by defaul…
slavapestov May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/swift/Basic/LangOptions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,9 @@ namespace swift {
/// rewrite system.
bool EnableRequirementMachineOpaqueArchetypes = false;

/// Enable warnings for redundant requirements in generic signatures.
bool WarnRedundantRequirements = false;

/// Enables dumping type witness systems from associated type inference.
bool DumpTypeWitnessSystems = false;

Expand Down
3 changes: 3 additions & 0 deletions include/swift/Option/FrontendOptions.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,9 @@ def disable_requirement_machine_reuse : Flag<["-"], "disable-requirement-machine
def enable_requirement_machine_opaque_archetypes : Flag<["-"], "enable-requirement-machine-opaque-archetypes">,
HelpText<"Enable more correct opaque archetype support, which is off by default because it might fail to produce a convergent rewrite system">;

def warn_redundant_requirements : Flag<["-"], "warn-redundant-requirements">,
HelpText<"Emit warnings for redundant requirements in generic signatures">;

def dump_type_witness_systems : Flag<["-"], "dump-type-witness-systems">,
HelpText<"Enables dumping type witness systems from associated type inference">;

Expand Down
1 change: 1 addition & 0 deletions lib/AST/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ add_swift_host_library(swiftAST STATIC
RequirementEnvironment.cpp
RequirementMachine/ConcreteContraction.cpp
RequirementMachine/ConcreteTypeWitness.cpp
RequirementMachine/Diagnostics.cpp
RequirementMachine/GenericSignatureQueries.cpp
RequirementMachine/HomotopyReduction.cpp
RequirementMachine/InterfaceType.cpp
Expand Down
Loading