[5.7-04182022] Fix source range computation of regex literals for diagnostics #58864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unfortunately needed to ensure we correctly re-lex regex literal tokens correctly, which is needed for diagnostic logic to correctly compute source ranges. rdar://92469692
|
@swift-ci please test |
airspeedswift
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.7-04182022 cherry-pick of #58823
Start recording the locations of regex literals on the SourceManager, and using this information to re-lex them as regex literals. This is unfortunately needed to ensure we correctly compute source ranges for diagnostic logic.
rdar://92469692