[5.7][Parseable Output] Compute file extensions using full extension strings #58868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
changed the title
|
@swift-ci please test |
artemcm
force-pushed
the
57ParseableFixFileTypes
branch
from
fc0415c to
584d0a3
Compare
Generation of valid JSON output for parseable output depends on being able to determine file types of inputs and outputs of compilation tasks. FileTypes.def defines multiple file kinds with multiple '.' extensions, such as '.abi.json' or '.features.json', but existing code attempted to compute file outputs only using the trailing suffix of the path after the last '.'. This led to some files not being recognized, which led to us not being able to generate valid JSON. Resolves rdar://92961252
artemcm
force-pushed
the
57ParseableFixFileTypes
branch
from
584d0a3 to
1177051
Compare
|
@swift-ci please test |
nkcsgexi
approved these changes
May 12, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #58865
Generation of valid JSON output for parseable output depends on being able to determine file types of inputs and outputs of compilation tasks. FileTypes.def defines multiple file kinds with multiple . extensions, such as .abi.json or .features.json, but existing code attempted to compute file outputs only using the trailing suffix of the path after the last .. This led to some files not being recognized, which led to us not being able to generate valid JSON.
We have this problem broadly in other places in the compiler but I wanted to have a narrow fix for this release first.
Resolves rdar://92961252