Optimizer: add the ObjCBridgingOptimization to optimize ObjectiveC bridging operations. #58888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci benchmark |
al45tair
reviewed
May 13, 2022
| /// none_bb: | ||
| /// %5 = enum #none | ||
| /// br continue_bb(%5) | ||
| /// continue_bb(%bridgedOptionalSwiftVaule): |
al45tair
reviewed
May 13, 2022
| let originalObjCValue = bridgeToSwiftCall.arguments[0] | ||
| let optionalObjCType = originalObjCValue.type | ||
|
|
||
| // The briding functions from ObjC -> Swift take an optional argument and return a |
There was a problem hiding this comment.
(very minor) Another typo, should be "bridging". (Sorry, just reading through this out of interest.)
eeckstein
force-pushed
the
objc-string-opt
branch
from
06ade1f to
71fdf81
Compare
|
@swift-ci test |
eeckstein
force-pushed
the
objc-string-opt
branch
from
71fdf81 to
5bda97d
Compare
|
@swift-ci test |
In case of type-dependent operands, not all operands are part of the arguments
…idging operations. Removes redundant ObjectiveC <-> Swift bridging calls. Basically, if a value is bridged from ObjectiveC to Swift an then back to ObjectiveC again, then just re-use the original ObjectiveC value. Also in this commit: add an additional DCE pass before ownership elimination. It can cleanup dead code which is left behind by the ObjCBridgingOptimization. rdar://89987440
It's replaced by the new ObjCBridgingOptimization optimization pass
eeckstein
force-pushed
the
objc-string-opt
branch
from
5bda97d to
9f70c29
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes redundant ObjectiveC <-> Swift bridging calls.
Basically, if a value is bridged from ObjectiveC to Swift an then back to ObjectiveC again, then just re-use the original ObjectiveC value.
Also, add an additional DCE pass before ownership elimination. It can cleanup dead code which is left behind by the ObjCBridgingOptimization.
This PR also removes an old obsolete bridging optimization from SILCombine.
rdar://89987440