[5.7] Support hermetic indexing information #58946
Merged
+256
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftc port of swiftlang/llvm-project#4207. This introduces a new flag, `-file-prefix-map` which can be used instead of the existing `-debug-prefix-map` and `-coverage-prefix-map` flags, and also remaps paths in index information currently.
bnbarham
changed the title
|
@swift-ci please test |
airspeedswift
approved these changes
May 19, 2022
keith
added a commit
to bazelbuild/rules_swift
that referenced
this pull request
Sep 14, 2022
This is a new flag in Swift 5.7, that mirrors the flag with the same name in clang, meaning that it implies both -debug-prefix-map, and -coverage-prefix map. Currently it is also the only flag that applies to indexing info if you want to produce hermetic indexes. Ideally going forward users should prefer this flag if they want their builds to be hermetic instead of picking the other flags as needed, since this will potentially also apply to new absolute paths in the future. swiftlang/swift#58946
keith
added a commit
to bazelbuild/rules_swift
that referenced
this pull request
Sep 14, 2022
This is a new flag in Swift 5.7, that mirrors the flag with the same name in clang, meaning that it implies both -debug-prefix-map, and -coverage-prefix map. Currently it is also the only flag that applies to indexing info if you want to produce hermetic indexes. Ideally going forward users should prefer this flag if they want their builds to be hermetic instead of picking the other flags as needed, since this will potentially also apply to new absolute paths in the future. swiftlang/swift#58946
keith
added a commit
to bazelbuild/rules_swift
that referenced
this pull request
Sep 15, 2022
This is a new flag in Swift 5.7, that mirrors the flag with the same name in clang, meaning that it implies both -debug-prefix-map, and -coverage-prefix map. Currently it is also the only flag that applies to indexing info if you want to produce hermetic indexes. Ideally going forward users should prefer this flag if they want their builds to be hermetic instead of picking the other flags as needed, since this will potentially also apply to new absolute paths in the future. swiftlang/swift#58946
AnthonyLatsis
added
🍒 release cherry pick
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
This is a new flag in Swift 5.7, that mirrors the flag with the same name in clang, meaning that it implies both -debug-prefix-map, and -coverage-prefix map. Currently it is also the only flag that applies to indexing info if you want to produce hermetic indexes. Ideally going forward users should prefer this flag if they want their builds to be hermetic instead of picking the other flags as needed, since this will potentially also apply to new absolute paths in the future. swiftlang/swift#58946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #42394 to release/5.7.
Swiftc port of swiftlang/llvm-project#4207.
This introduces a new flag,
-file-prefix-mapwhich can be usedinstead of the existing
-debug-prefix-mapand-coverage-prefix-mapflags, and also remaps paths in index information currently.
This requires swiftlang/llvm-project#4688 to be merged at the same time (since they depend upon one another due to API changes).