[5.7][SwiftSyntax] Parse regex literals using a fallback lexer implemented in C++ #58998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in C++ `libInternalSwiftSyntaxParser.dylib` currently doesn’t link against `SwiftExperimentalStringProcessing`, so it can’t use the regex lexing functions defined within. This caused SwiftSyntax to fail if the source code contained regex literals. Implement a fallback regex lexing function in C++ and use it for SwiftSyntax parsing. rdar://93580240 Co-authored-by: Rintaro Ishizaki <[email protected]>
ahoppen
force-pushed
the
pr-5.7/regex-literal-parsing-swiftsyntax
branch
from
00aff1b to
719ea8c
Compare
|
@swift-ci Please test |
…ed at the end of the file Fixes a SwiftSyntax parsing assertion failure if there is a regex literal at the end of the file. I.e. either a single line regex literal in a file without a trailing newline or a multi-line regex literal. This does not crash in non-assert builds.
|
@swift-ci Please test |
airspeedswift
approved these changes
May 27, 2022
This was referenced May 30, 2022
[5.7][SwiftSyntax] Add an API to enable or disable bare slash regex literals from SwiftSyntax
#59150
Merged
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libInternalSwiftSyntaxParser.dylibcurrently doesn’t link againstSwiftExperimentalStringProcessing, so it can’t use the regex lexing functions defined within. This caused SwiftSyntax to fail if the source code contained regex literals.Implement a fallback regex lexing function in C++ and use it for SwiftSyntax parsing.