[SwiftCompilerSources][build] Require recent Swift compiler in HOSTTOOLS mode
#59020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
eeckstein
requested changes
May 31, 2022
CMakeLists.txt
Outdated
| elseif(BOOTSTRAPPING_MODE MATCHES "BOOTSTRAPPING.*") | ||
| # If cross-compiling, we don't have to bootstrap. We can just use the previously | ||
| # built native swiftc to build the swift compiler modules. | ||
| message(STATUS "Building swift modules with previously built tools instead of bootstrapping") | ||
| set(SWIFT_EXEC_FOR_SWIFT_MODULES "${SWIFT_NATIVE_SWIFT_TOOLS_PATH}/swiftc") | ||
| if(NOT "${SWIFT_NATIVE_SWIFT_TOOLS_PATH}/swiftc" STREQUAL "${CMAKE_Swift_COMPILER}") |
There was a problem hiding this comment.
I'm pretty sure that this will break cross-compilation.
For cross-compilation we don't use the installed swift compiler, but the previously built swiftc.
See https://github.com/apple/swift/blob/98895861fa7f03f126b996648b87ea42c91c0b33/utils/build-script-impl#L2026
There was a problem hiding this comment.
Oh I didn't know that, thanks! I think in cross-compilation mode we don't actually need the version check, since we're using a compiler that was just built. I'll make sure it only runs in hosttools mode.
…OOLS` mode Some code in SwiftCompilerSources, especially the parts that use C++ interop, triggers bugs in older versions of the Swift compiler. To make sure that `HOSTTOOLS` builds don't produce obscure compiler errors or crashes, let's require a relatively new Swift compiler for `HOSTTOOLS` build.
egorzhdan
force-pushed
the
egorzhdan/libswift-version-check
branch
from
5010c03 to
2b3980b
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code in SwiftCompilerSources, especially the parts that use C++ interop, triggers bugs in older versions of the Swift compiler. To make sure that
HOSTTOOLSbuilds don't produce obscure compiler errors or crashes, let's require a relatively new Swift compiler forHOSTTOOLSbuild.Since the CI currently uses Xcode 13.0 beta, let's require Swift 5.5 for now to avoid breaking the CI.