[SILOpt] Used SetVector for fast contains check. #59057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IterableBackwardReachability just requires an iterable list of gens. ShrinkBorrowScope, LexicalDestroyHoisting, and SSADestroyHoisting all need to be able to check whether a given instruction is scope ending quickly. Use a SmallSetVector rather than a SmallVector for the gens in all three.
nate-chandler
force-pushed
the
perf/20220524/use-setvector-for-gens
branch
from
b6536af to
8775148
Compare
|
@swift-ci please test |
|
@swift-ci please test linux platform |
|
@swift-ci please test macos platform |
|
LGTM For the record, this probably was not an issue in practice. We need to be careful not to iterate over all uses. But if we know the "use set" only contains scope ending instructions (destroys or end_borrows), then there can only be one per block. So you would need some kind of giant switch where the destroys were all hoisted. |
|
Except for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IterableBackwardReachability just requires an iterable list of gens. ShrinkBorrowScope, LexicalDestroyHoisting, and SSADestroyHoisting all need to be able to check whether a given instruction is scope ending quickly. Use a SmallSetVector rather than a SmallVector for the gens in all three.