[5.7] Frontend: add an additional search path for swift modules #59073
Conversation
This setups the frontend to search both an architecture suffixed and unsuffixed path. This improves the multi-architecture setup for Windows, enabling it use the directory form of the swift modules with the architectures overlaying in the swift module and leaving the arch suffixed directory for the import libraries. This can be fully generalized as this also enables Linux to use the multi-architecture search path for the swift modules enabling it to eventually adopt a SDK model as well.
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
@swift-ci please test |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
The Windows toolchain error is unrelated to this change - there is something missing on the 5.7 branch for Foundation on Windows. Nominating this for 5.7 as it helps the Windows SDK layout (allowing the removal of the duplicated architecture). It is adding an additional module search path to the non-Darwin paths, which should be extremely low risk for Darwin, and low risk for Linux and Windows as it simply adds an additional search path. CC: @airspeedswift |
|
LGTM. I'll let one of the branch owners more versed in CMake sign off on it, though. |
compnerd
changed the title
AnthonyLatsis
added
🍒 release cherry pick
This setups the frontend to search both an architecture suffixed and
unsuffixed path. This improves the multi-architecture setup for
Windows, enabling it use the directory form of the swift modules with
the architectures overlaying in the swift module and leaving the arch
suffixed directory for the import libraries.
This can be fully generalized as this also enables Linux to use the
multi-architecture search path for the swift modules enabling it to
eventually adopt a SDK model as well.