[5.7][CSClosure] Fix crash in fallthrough statement checking
#59083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fallthrough` requires both source and destination `case` "preambles" be type-checked before it could be validated, which means that solution application for `case` statements in a `switch` has to be split in two - preamble first and bodies afterwards. Resolves: swiftlang#59035 Resolves: rdar://93796211 (cherry picked from commit 4e9992c)
|
@swift-ci please test |
hborla
approved these changes
May 25, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #59059
fallthroughrequires both source and destinationcase"preambles" be type-checked before it could be validated,
which means that solution application for
casestatementsin a
switchhas to be split in two - preamble first andbodies afterwards.
Resolves: #59035
Resolves: rdar://93796211
(cherry picked from commit 4e9992c)