Add -enable-experimental-feature X for experimental features. #59113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimental features can only be enabled in non-production (+Asserts) builds. They can be detected with `hasFeature` in the same manner as "future" features. The `-enable-experimental-feature X` flag will also look for future features by that name, so that when an experimental feature becomes an accepted future feature, it will still be enabled in the same manner. Switch variadic generics over to this approach, eliminating the specific LangOption for it.
|
@swift-ci please smoke test |
|
Looking forward to applying this to interop too! Thanks for the patch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a simpler declarative approach to describing experimental features, where each feature has its own feature identifier (e.g.,
VariadicGenerics). The feature can be enabled with the-enable-experimental-feature FeatureNameflag, and detected with#if $FeatureName. This metaprograms away the need to add new language options and compiler options each time we stage in a new experimental feature. Experimental features can only be enabled in non-production (+Asserts) builds.Adopt this mechanism for a number of experimental features: variadic generics, static asserts, named opaque types, move-only, one-way closure parameters, and associated type witness inference via type witness systems.
Map the existing "experimental" flags over to the new system, but don't remove them just yet.