ModuleInterface: Fix decl attribute corruption in private swiftinterfaces #59128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
xymus
approved these changes
May 27, 2022
tshortli
force-pushed
the
inconsistent-attributes-in-private-swift-interfaces
branch
from
8cd64cc to
551464f
Compare
…aces Erroneous declaration attributes were sometimes being printed in the private swiftinterfaces of modules because the changes from swiftlang#42276 were effectively corrupting the attribute list for any decl with sythesized conformances (e.g. `Equatable`, `Hashable`). It is necessary to clone the attributes before adding them to the synthesized conformance extension decls. Resolves rdar://94009296
tshortli
force-pushed
the
inconsistent-attributes-in-private-swift-interfaces
branch
from
551464f to
7b1d4df
Compare
|
@swift-ci please smoke test |
nkcsgexi
approved these changes
May 31, 2022
This was referenced May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erroneous declaration attributes were sometimes being printed in the private swiftinterfaces of modules because the changes from #42276 were effectively corrupting the attribute list for any decl with sythesized conformances (e.g.
Equatable,Hashable). It is necessary to clone the attributes before adding them to the synthesized conformance extension decls.Resolves rdar://94009296