re-exported synthesized extensions need to go under the base module #59129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
franklinsch
approved these changes
May 27, 2022
|
@swift-ci Please test |
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://93928003
When a module adds a type as an extension of a foreign type, then a different module re-exports that module, the synthesized symbols currently get sorted incorrectly. The check that determines what module's graph they go in incorrectly uses the module of the decl, instead of the root module that the symbol is extending. This PR changes that check, so that modules in the aforementioned situation don't incorrectly receive symbols that can't be matched up with their parent.