🍒 [5.7] SE-0309: SILOptimizer fixes & reenable executable tests #59138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'apply' involves non-root opened archetypes This optimization rewrites only the 'self' argument, and does not know how to substitute types in the users of the given apply instruction in case the underlying protocol method involved `Self`-dependent types. With SE-0309 in motion, the bail-out logic must be generalized to non-root opened archetypes.
…meters and `Self`-rooted type parameters
tbkka
approved these changes
May 31, 2022
|
@swift-ci please test |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Selfnested inside a collection type, because it does not handle the associated collection upcasts.createApplyWithConcreteTypeoptimization does not support cases with covariantSelf.With SE-0309, these limitations must be extended to
Self-rooted type parameters (or non-root opened archetypes), and the former must also look out for variadic parameters, which desugar to arrays.Scope: SE-0309 paths that previously crashed.
Risk: Low.
Reviewers: @slavapestov
Testing: Regression tests.
Original PR: SE-0309: SILOptimizer fixes & reenable executable tests #58513