Skip to content

🍒 [5.7] DiagnosticEngine: Print any in 'aka' types #59155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2022
Merged

🍒 [5.7] DiagnosticEngine: Print any in 'aka' types #59155

merged 1 commit into from
May 31, 2022

Conversation

AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented May 30, 2022 •
edited
Loading

  • Description: We ought to be passing the same options we use for printing type arguments. Besides any, doing so also mirrors type qualification and inclusion of function convention attributes in 'aka' types, which makes sense.
  • Risk: Very low.
  • Tests: Updated existing tests.
  • Original PR: DiagnosticEngine: Print any in 'aka' types #59147

@AnthonyLatsis AnthonyLatsis requested a review from a team as a code owner May 30, 2022 13:04
@AnthonyLatsis AnthonyLatsis changed the title DiagnosticEngine: Print any in 'aka' types 🍒 [5.7] DiagnosticEngine: Print any in 'aka' types May 30, 2022
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test

@AnthonyLatsis AnthonyLatsis merged commit 28a2c60 into swiftlang:release/5.7 May 31, 2022
@AnthonyLatsis AnthonyLatsis deleted the 5.7-print-any-in-aka branch May 31, 2022 18:47
@hborla hborla mentioned this pull request Jun 22, 2022
Merged
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyLatsis @hborla