[cxx-interop] Do not warn about missing libstdc++ on Android #59156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @buttaface |
|
@swift-ci please smoke test |
finagolfin
approved these changes
May 30, 2022
Android uses libc++. This fixes a few tests on Android.
egorzhdan
force-pushed
the
egorzhdan/cxx-android-warning
branch
from
40e4ba2 to
127e29f
Compare
|
@swift-ci please smoke test |
|
Happy to report this fixes 11 failing tests on the Android CI, with another 7 tests that started failing recently apparently unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android uses libc++.
This fixes a few tests on Android.