ClosureLifetimeFixup : Fix bug in lifetime extension of non escaping closure #59160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test and merge |
meg-gupta
force-pushed
the
closurefixupbug
branch
from
b882a4c to
8d204ad
Compare
|
@swift-ci test |
atrick
approved these changes
May 31, 2022
There was a problem hiding this comment.
Awesome! Very nice. Thank you.
Maybe @aschwaighofer will want to take a lot too.
Do you think there should be a SIL test to make it clear what the transformation actually does? Or maybe use the option to dump the OSSA module? The final non-OSSA SIL is a little confusing.
meg-gupta
force-pushed
the
closurefixupbug
branch
from
8d204ad to
defafa7
Compare
|
@swift-ci smoke test |
|
@atrick Thanks. Added a SIL test |
|
cc @eeckstein @nate-chandler Here's the fix for the closure lifetime issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.