cmake: add android runtime build caches #59173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These cache files allow building the runtime via cross-compilation for Android ARMv7 and AArch64.
|
@swift-ci please smoke test |
|
Oh, nice, how are these to be used? |
finagolfin
reviewed
Jun 3, 2022
| # NOTE(compnerd) this is lollipop, which seems to still have decent usage. | ||
| set(SWIFT_ANDROID_API_LEVEL 21 CACHE STRING "") | ||
| # NOTE(compnerd) this matches the value from the NDK r24. | ||
| set(SWIFT_ANDROID_NDK_CLANG_VERSION 14.0.1 CACHE STRING "" FORCE) |
There was a problem hiding this comment.
The latest LTS NDK 23c was just released and it uses 12.0.9, I think it'd be better to use that but up to you. I was planning on submitting a pull updating that in the default CMake configuration and the docs.
There was a problem hiding this comment.
I think that going with the latest release is reasonable, but so is the LTS release. I think that I am going to go with this for the time being, but this is something to revisit in the future. A more interesting thing would be to see if we can completely remove the need to specify the version and compute that dynamically instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cache files allow building the runtime via cross-compilation for
Android ARMv7 and AArch64.