Skip to content

Increase expectation slop for clock tests #59180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Increase expectation slop for clock tests #59180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/Concurrency/Runtime/clock.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var tests = TestSuite("Time")
}
// give a reasonable range of expected elapsed time
expectGT(elapsed, .milliseconds(90))
expectLT(elapsed, .milliseconds(200))
expectLT(elapsed, .milliseconds(1000))
}

tests.test("ContinuousClock sleep with tolerance") {
Expand All @@ -33,15 +33,15 @@ var tests = TestSuite("Time")
}
// give a reasonable range of expected elapsed time
expectGT(elapsed, .milliseconds(90))
expectLT(elapsed, .milliseconds(300))
expectLT(elapsed, .milliseconds(2000))
}

tests.test("ContinuousClock sleep longer") {
let elapsed = await ContinuousClock().measure {
try! await Task.sleep(until: .now + .seconds(1), clock: .continuous)
}
expectGT(elapsed, .seconds(1) - .milliseconds(90))
expectLT(elapsed, .seconds(1) + .milliseconds(200))
expectLT(elapsed, .seconds(1) + .milliseconds(1000))
}

tests.test("SuspendingClock sleep") {
Expand All @@ -51,7 +51,7 @@ var tests = TestSuite("Time")
}
// give a reasonable range of expected elapsed time
expectGT(elapsed, .milliseconds(90))
expectLT(elapsed, .milliseconds(200))
expectLT(elapsed, .milliseconds(1000))
}

tests.test("SuspendingClock sleep with tolerance") {
Expand All @@ -61,15 +61,15 @@ var tests = TestSuite("Time")
}
// give a reasonable range of expected elapsed time
expectGT(elapsed, .milliseconds(90))
expectLT(elapsed, .milliseconds(300))
expectLT(elapsed, .milliseconds(2000))
}

tests.test("SuspendingClock sleep longer") {
let elapsed = await SuspendingClock().measure {
try! await Task.sleep(until: .now + .seconds(1), clock: .suspending)
}
expectGT(elapsed, .seconds(1) - .milliseconds(90))
expectLT(elapsed, .seconds(1) + .milliseconds(200))
expectLT(elapsed, .seconds(1) + .milliseconds(1000))
}

tests.test("duration addition") {
Expand Down