Skip to content

[5.7][build-script] Cross-compile sourcekit-lsp for arm64 #59196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2022
Merged

[5.7][build-script] Cross-compile sourcekit-lsp for arm64 #59196

merged 1 commit into from
Jun 24, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 1, 2022

  • Explanation: Currently, when building an open source toolchain, SourceKit-LSP is only built for x86_64. Copy the cross-compilation config from swiftpm.py to also produce a fat sourcekit-lsp executable for both x86_64 and arm64.
  • Scope: The way SourceKit-LSP is built in open source toolchains
  • Risk: These changes to the build process are always a little risky, but I think we should be able to catch any issues once the next open source toolchain is released
  • Testing: Verified that the binary produced by [build-script] Cross-compile sourcekit-lsp for arm64 #59046 was fat (x86_64 and arm64) and ran on arm64
  • Issue: rdar://78039145
  • Reviewer: @benlangmuir, @buttaface on [build-script] Cross-compile sourcekit-lsp for arm64 #59046

Companion of swiftlang/sourcekit-lsp#561.

@ahoppen
[build-script] Cross-compile sourcekit-lsp for arm64
f24eb40 
Currently, when building an open source toolchain, SourceKit-LSP is only built for x86_64. Copy the cross-compilation config from swiftpm.py to also produce a fat sourcekit-lsp executable for both x86_64 and arm64.

rdar://78039145
@ahoppen ahoppen added the r5.7 label Jun 1, 2022
@ahoppen ahoppen requested a review from airspeedswift June 1, 2022 07:49
@ahoppen ahoppen requested a review from a team as a code owner June 1, 2022 07:49
@ahoppen ahoppen mentioned this pull request Jun 1, 2022
Merged
@ahoppen
Copy link
Member Author

ahoppen commented Jun 1, 2022

swiftlang/sourcekit-lsp#561

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jun 1, 2022

swiftlang/sourcekit-lsp#561

@swift-ci Please build toolchain

@ahoppen
Copy link
Member Author

ahoppen commented Jun 1, 2022

swiftlang/sourcekit-lsp#561

@swift-ci Please test macOS

@ahoppen
Copy link
Member Author

ahoppen commented Jun 1, 2022

swiftlang/sourcekit-lsp#561

@swift-ci Please build toolchain macOS

@ahoppen
Copy link
Member Author

ahoppen commented Jun 22, 2022

@swift-ci Please build toolchain Windows

@ahoppen ahoppen merged commit a226261 into swiftlang:release/5.7 Jun 24, 2022
@ahoppen ahoppen deleted the pr-5.7/fat-sourcekit-lsp branch June 24, 2022 05:53
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

@finagolfin finagolfin finagolfin approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahoppen @airspeedswift @finagolfin @AnthonyLatsis