Change message of invalid_iboutlet and invalid_ibinspectable to reflect accurate usage

[NSAntoine]

The current error message for when @GKInspectable, @IBInspectable, and @IBOutlet is only instance properties can be declared @GKInspectable / @IBInspectable / @IBOutlet, however it doesn't reflect that it should be an instance property of a class, just that it should be an instance property, though those attributes are only allowed to be used for instance properties of a class type.

This pull request changes the message so that it should reflect the attribute should be used on a class instance property.

[NSAntoine]

@AnthonyLatsis This one is simple and should work the first time, could you ask it to test? :)

[AnthonyLatsis]

@swift-ci please smoke test macOS

[AnthonyLatsis]

Looks like those two error macros are pretty much identical, and we can get rid of the one that hardcodes IBOutlet in favor of the other one that takes a string argument, and pass attr->getName for IBOutletAttr. Do you mind cleaning that up as well?

[NSAntoine]

Looks like those two error macros are pretty much identical, and we can get rid of the one that hardcodes IBOutlet in favor of the other one that takes a string argument, and pass attr->getName for IBOutletAttr. Do you mind cleaning that up as well?

I noticed this yesterday and wanted to replace the hardcoded one but thought maybe I shouldn’t overcomplicate the pr but it should be fine now that I think about it, I’ll do it once I’m near my computer again

[NSAntoine]

@AnthonyLatsis

[AnthonyLatsis]

Looks great, thank you!

[NSAntoine]

@AnthonyLatsis may be redundant but shouldn’t we run tests just one more time to make sure nothing got messed up?

[AnthonyLatsis]

Sure.

@swift-ci please smoke test macOS

[hborla]

Nice improvement!

[hborla]

@swift-ci please smoke test

[AnthonyLatsis]

@SerenaKit Before we merge, could you rebase this into 2 commits, one for the message edit and another one for the gardening? Would also be nice if the second commit message was a tad more specific.

[NSAntoine]

@AnthonyLatsis There, should be fine now (I think)

[AnthonyLatsis]

@swift-ci please smoke test and merge