[Diagnostics] Diagnose conflicting pattern variables #59210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
force-pushed
the
conflicting-patterns-in-case
branch
from
914b2e7 to
7ce6fa6
Compare
xedin
force-pushed
the
conflicting-patterns-in-case
branch
from
7ce6fa6 to
117ae23
Compare
The fix indentifies the conflicting variables and the expected "join" type e.g. `case .a(let x), .b(let x)` where `a(Int)` and `b(String)`.
Diagnose situations where pattern variables with the same name
have conflicting types:
```swift
enum E {
case a(Int)
case b(String)
}
func test(e: E) {
switch e {
case .a(let x), .b(let x): ...
}
}
```
In this example `x` is bound to `Int` and `String` at the same
time which is incorrect.
… statements Avoid mutating case label items while solving, instead let's use types recorded in the constraint system for each pattern variable and use that for var reference in the case body. This also helps to detect and diagnose type conflicts while solving.
xedin
force-pushed
the
conflicting-patterns-in-case
branch
from
117ae23 to
9c8bebe
Compare
|
@swift-ci please test |
hborla
approved these changes
Jun 14, 2022
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnose situations where pattern variables with the same name
have conflicting types:
In this example
xis bound toIntandStringat the sametime which is incorrect.