Skip to content

[Driver] Pass target triple to -modulewrap invocations #5922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

Jnosh
Copy link
Contributor

@Jnosh Jnosh commented Nov 25, 2016

-modulewrap invocations create an object file.

The target should be passed along so that the object file is created for the same target as any other outputs.

-modulewrap invocations create an object file.
The target should be passed along so that the object file is created for the same target as any other outputs.
@Jnosh Jnosh force-pushed the module-wrap-with-target branch from 151761f to 9f18115 Compare November 25, 2016 08:52
@CodaFi
Copy link
Contributor

CodaFi commented Nov 26, 2016

LGTM, but this is probably one for @jrose-apple.

@swift-ci please smoke test.

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Janosh!

@jrose-apple jrose-apple merged commit 292e6a9 into swiftlang:master Nov 28, 2016
@Jnosh Jnosh deleted the module-wrap-with-target branch November 28, 2016 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants