AST: Fix debug info mangling of opaque result types with @_originallyDefinedIn #59234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
opaque-result-type-debug-info-mangling
branch
from
b6f7d69 to
a3db8d4
Compare
…DefinedIn If a function's parameter or return types involve nominal types that have been moved across modules using @_originallyDefinedIn, we must take care to always mangle the opaque result type's name using the original module names and not the current module names. This was a problem with DWARF mangling, which normally disables @_originallyDefinedIn for other purposes. Make sure to always temporarily re-enable it when mangling an opaque result type. Fixes rdar://problem/93822207.
slavapestov
force-pushed
the
opaque-result-type-debug-info-mangling
branch
from
a3db8d4 to
beec309
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a function's parameter or return types involve nominal types that
have been moved across modules using @_originallyDefinedIn, we must
take care to always mangle the opaque result type's name using the
original module names and not the current module names.
This was a problem with DWARF mangling, which normally disables
@_originallyDefinedIn for other purposes. Make sure to always
temporarily re-enable it when mangling an opaque result type.
Fixes rdar://problem/93822207.