Skip to content

[5.7] Increase expectation slop for clock tests #59247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2022
Merged

[5.7] Increase expectation slop for clock tests #59247

merged 1 commit into from
Jun 3, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 3, 2022

Cherry-pick #59180 by @phausler to release/5.7

  • Explanation: Sadly server load makes some of the clock tests fail; heavier loads on the CI servers means that scheduling may get delayed even without tolerances (which is expected behavior). This increases the slop in the tests to ensure they are remotely reasonable by increasing the timeout to 10x of the sleep duration (which hopefully should be reasonable in almost all cases)
  • Scope: Only tests
  • Risk: Low (only affects tests)
  • Testing: N/a (only affects flaky tests)
  • Issue: rdar://94158711
  • Reviewer: Pending

@ahoppen ahoppen requested a review from a team as a code owner June 3, 2022 08:08
@ahoppen ahoppen changed the title Increase expectation slop for clock tests [5.7] Increase expectation slop for clock tests Jun 3, 2022
@ahoppen ahoppen added the r5.7 label Jun 3, 2022
@ahoppen
Copy link
Member Author

ahoppen commented Jun 3, 2022

@swift-ci Please test

@stephentyrone stephentyrone merged commit 90fc51f into swiftlang:release/5.7 Jun 3, 2022
@ahoppen ahoppen deleted the pr-5.7/addtional_clock_test_slop branch July 20, 2022 13:21
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentyrone stephentyrone stephentyrone approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahoppen @stephentyrone @AnthonyLatsis @phausler