[CSApply] Fixed type-checked subexpression output bug for multi-state… #59260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
approved these changes
Jun 3, 2022
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@amritpan Linux failures are what I was afraid of - looks putting |
amritpan
force-pushed
the
multi-statement-closure-output
branch
from
6dbaaa9 to
3ad8638
Compare
amritpan
force-pushed
the
multi-statement-closure-output
branch
from
3ad8638 to
9a0978a
Compare
amritpan
force-pushed
the
multi-statement-closure-output
branch
from
6dbaaa9 to
3a38d7a
Compare
xedin
reviewed
Jun 17, 2022
xedin
reviewed
Jun 17, 2022
amritpan
force-pushed
the
multi-statement-closure-output
branch
from
380ff81 to
38d6ea8
Compare
…e-checked to show their application solution status, as applicable for tap expressions and multi-statement closures.
amritpan
force-pushed
the
multi-statement-closure-output
branch
from
38d6ea8 to
d7266d6
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ment closures
Previously the type-checked subexpressions of a multi-statement closure were being printed with only partial bindings. This fix ensures that subexpressions are printed with all of their type-checked bindings.