Skip to content

[5.7][CodeCompletion] Don't suggest precedence groups in expr/type position #59267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 3, 2022

Cherry-pick #59263 into release/5.7

  • Explanation: Precedence groups should be suggested only at after colon in operator decls, and after higherThan: or lowerThan: in precedence group decls. Stop suggesting them in expression position
  • Scope: Global completion at expression position
  • Risk: Low.
  • Issue: rdar://76977760
  • Testing: Added regression test cases
  • Reviewer: Ben Barham (@bnbarham)

Precedence groups should be suggested only at
* After colon in operator decls
* After 'higherThan:' or 'lowerThan:' in precedence group decls

rdar://76977760
(cherry picked from commit 8fe890b)
@rintaro rintaro requested a review from a team as a code owner June 3, 2022 23:36
@rintaro
Copy link
Member Author

rintaro commented Jun 3, 2022

@swift-ci Please test

@rintaro rintaro merged commit f89eddf into swiftlang:release/5.7 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants