[build] Merge Clang's features.json from binary directory, handle values #59280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansvoboda11
force-pushed
the
jan_svoboda/features_json
branch
from
5f1321c to
f9c5c45
Compare
jakepetroules
approved these changes
Jun 6, 2022
|
@swift-ci please smoke test |
bnbarham
approved these changes
Jun 6, 2022
|
macOS failure looks unrelated. Going to test with the LLVM PR to make sure that passes too. |
|
@swift-ci please smoke test |
|
Whoops, that PR is on next. @jansvoboda11 could you open a cherry-pick PR for stable/20211026 so we can test it? |
|
@swift-ci please smoke test |
|
Heh, I guess changing base branch also works 👍 |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch picks up the
features.jsonfile from Clang's build directory instead of the source directory and takes into account the new"value"key. This is necessary due to swiftlang/llvm-project#4803.rdar://91377604