Fix actor/job/task leaks in the back deployment runtime. #59288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… library. Change the order of paths provided for `DYLD_LIBRARY_PATH` when running tests for the back-deployed concurrency library, so they supersede the ones in `/usr/lib/swift`. This way, we can test the back-deployed concurrency library even on OS's that have the concurrency library in them. It's not a complete test, because the standard library and runtime will still vary, but can reproduce many failures more easily. When using the back-deployed concurrency library, set the lit feature `back_deploy_concurrency`. Update some tests that are unsupported with back-deployment to check this. Finally, add some logging when the concurrency runtime cannot be tested at all, to help with debugging CI in the future.
When initializing an actor, job, or task, use _swift_instantiateInertHeapObject to have the OS's libswiftCore set up the object's refcounts field, to ensure we get a valid initial state. There is no equivalent for immortal objects, but by a stroke of luck the new representation for immortal refcounts happens to set the immortal bit in the old representation. rdar://93087343
This detects a bug unique to the oldest back-deployment targets for Swift concurrency, where Tasks were getting created with an incorrect bit pattern that made them immortal. Verifies that rdar://93087343 has been fixed.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing an actor, job, or task, use _swift_instantiateInertHeapObject to have the OS's libswiftCore set up the object's refcounts field, to ensure we get a valid initial state.
There is no equivalent for immortal objects, but by a stroke of luck the new representation for immortal refcounts happens to set the immortal bit in the old representation.
rdar://93087343