Skip to content

[test] Explicitly specify --cmake %cmake for build_lld.test #59322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 8, 2022

I believe this was causing CMake to get built for the test case and make the test case take ~5min on Linux instead of ~15sec.

I believe this was causing CMake to get built for the test case and make the test case take ~5min on Linux instead of ~15sec.
@ahoppen ahoppen requested a review from gottesmm June 8, 2022 16:36
@ahoppen
Copy link
Member Author

ahoppen commented Jun 8, 2022

@swift-ci Please smoke test

@gottesmm
Copy link
Contributor

gottesmm commented Jun 8, 2022

LGTM.

@shahmishal shahmishal merged commit 23273d8 into swiftlang:main Jun 8, 2022
@ahoppen ahoppen deleted the pr/specify-cmake-build-lld-test branch July 20, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants