Skip to content

Implement typeref to demangle tree conversion for nested bound generics #59326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

augusto2112
Copy link
Contributor

No description provided.

@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

Copy link
Contributor

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Do we have test coverage for this in the validation tests?

Copy link
Contributor

@mikeash mikeash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One teeny cosmetic comment, LGTM.

return genericNode;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray blank line here.

@augusto2112 augusto2112 force-pushed the nested-typeref-to-node branch from d99e92e to 58b1ea6 Compare June 30, 2022 22:40
@augusto2112 augusto2112 force-pushed the nested-typeref-to-node branch from 58b1ea6 to 2ce0e14 Compare June 30, 2022 22:41
@augusto2112
Copy link
Contributor Author

@swift-ci smoke test

@augusto2112 augusto2112 closed this Jul 5, 2022
@augusto2112
Copy link
Contributor Author

I accidentally merged the correct version of this change here: #59262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants