[silgen] Teach SILGen how to handle a corner case where the clang importer is improperly importing a method with a non-null NSError as throwing #59334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API just wraps the current type T into an Optional<T> and returns the Optional<T> type. We use this all the time in the optimizer and I found I needed it in SILGen as well but at the AST level, hence the addition. In the next commit, I change the API in SILType that does this to use this helper instead. I am doing that to make it easier to cherry-pick this with a subsequent change I am making to fix a bug.
…lType() instead of rolling its own.
…on imported objc classes that are imported with a non-null NSError. This for some time has been crashing in IRGen in non-asserts builds and hitting assertions in asserts builds. I think we were missing test coverage here and that is why this basic-ish thing has been broken. Basically at a high level, the actual expected ABI here is that the NSError is marked non-nullable which is different from the expected ABI. rdar://92755102
|
@swift-ci test |
jckarter
approved these changes
Jun 8, 2022
|
I need to disable this on Linux/Windows due to objc. Going to let full Mac OS test pass and then fix linux/windows and do a smoke test |
|
@swift-ci smoke test |
gottesmm
force-pushed
the
pr-499eee4e1aca5a8f3f38d1aeb7507c6e761eccd7
branch
from
1a93026 to
71179c0
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been crashing a long time and has never been correct. From an API perspective, the clang importer should have not been importing these methods as throwing. Sadly, today, we need to preserve source compatibility, so in this PR I teach SILGen how to handle this case by passing a nullptr to the non-null API. With time (maybe swift 6), we will be able to eliminate this. I filed rdar://94656178 to track that.
rdar://92755102