Skip to content

[5.7][TypeChecker/CodeCompletion] Re-introduce expression sanitization bef… #59343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jun 9, 2022

…ore solving

A call to SanitizeExpr has been incorrectly removed from
typeCheckForCodeCompletion by refactoring to use ASTNode.

It is still required because fallback calls could have partially
type-checked AST.

Resolves: #59315
Resolves: rdar://94619388
(cherry picked from commit 3159591)

…ore solving

A call to `SanitizeExpr` has been incorrectly removed from
`typeCheckForCodeCompletion` by refactoring to use `ASTNode`.

It is still required because fallback calls could have partially
type-checked AST.

Resolves: swiftlang#59315
Resolves: rdar://94619388
(cherry picked from commit 3159591)
@xedin xedin requested a review from hborla June 9, 2022 17:05
@xedin xedin requested a review from a team as a code owner June 9, 2022 17:05
@xedin xedin changed the title [TypeChecker/CodeCompletion] Re-introduce expression sanitization bef… [5.7][TypeChecker/CodeCompletion] Re-introduce expression sanitization bef… Jun 9, 2022
@xedin xedin added the r5.7 label Jun 9, 2022
@xedin
Copy link
Contributor Author

xedin commented Jun 9, 2022

@swift-ci please test

@xedin xedin merged commit 7611f3f into swiftlang:release/5.7 Jun 10, 2022
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants