[test] Fix tests who aren't using %target-cpu #59433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
don't import string processing
|
@swift-ci please test |
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Jun 15, 2022
don't import string processing
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
Oct 21, 2022
don't import string processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were failing to find
_StringProcessingfor x86_64 on an arm64 bot who was explicitly not building x86_64 modules (how these weren't failing for things like the stdlib or other modules amazes me). Most of the changes are just using%target-cpuin the test files, but the IRGen test seems to explicitly want x86_64, so add a require.Resolves: rdar://95121796