[CodeCompletion] Avoid crash for not recommended item without a decl #59490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
bnbarham
reviewed
Jun 16, 2022
| @@ -30,3 +30,11 @@ func testActor(obj: MyActor) async { | |||
| // ACTOR-DAG: Decl[InstanceMethod]/CurrNominal/NotRecommended: receiveNonSendable({#arg: MyNonSendable#})[' async'][#Void#]; name=receiveNonSendable(arg:); diagnostics=warning:actor-isolated 'receiveNonSendable(arg:)' should only be referenced from inside the actor{{$}} | |||
| // ACTOR: End completions | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Would be good to test the contextual and context-free cases.
There was a problem hiding this comment.
There's no case where ContextFreeNotRecReason != None && AssociatedDecl == nulptr at this point. Added an assertion to clarify, but still use dyn_cast_or_null just in case.
There was a problem hiding this comment.
Seems reasonable, no crashes in release but we'll see with assertions enabled 👍
bnbarham
approved these changes
Jun 16, 2022
Generating diagnostics for "not recommended" items requires an
associated declaration. However, cases like this:
func test(fn: (Int) async -> Void) {
fn(#^HERE^#)
}
For the function call pattern item, there's no associated decl because
the callee is an expression. Ideally it should emit a diagnostic, but
for now, to avoid the crash, don't emit diagnostics unless the item has
the associated decl.
rdar://95306033
rintaro
force-pushed
the
ide-completion-rdar95306033
branch
from
a675932 to
e748ab4
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating diagnostics for "not recommended" items requires an associated declaration. However, cases like this:
For the function call pattern item, there's no associated decl because the callee is an expression. Ideally it should emit a diagnostic, but for now, to avoid the crash, don't emit diagnostics unless the item has the associated decl.
rdar://95306033