Handle store_borrow in SILMem2Reg and some other fixes #59541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
meg-gupta
force-pushed
the
mem2regstoreborrowpr
branch
5 times, most recently
from
9d156da to
158b0bd
Compare
|
@swift-ci benchmark |
atrick
reviewed
Jun 26, 2022
There was a problem hiding this comment.
Thanks for working on this. Let's see if there's a way to keep the original "borrow" semantics without copies. We need to store move-only values in store-borrow locations.
@nate-chandler can we also get your eyes on this and together come up with something that integrates well with the new support for lexical scopes?
…ad of computing in-place
meg-gupta
force-pushed
the
mem2regstoreborrowpr
branch
from
158b0bd to
0a7c7f3
Compare
|
@swift-ci test |
|
@swift-ci benchmark |
|
@swift-ci test source compatibility |
meg-gupta
force-pushed
the
mem2regstoreborrowpr
branch
from
0a7c7f3 to
2e4f48f
Compare
|
@swift-ci test |
|
@atrick @nate-chandler Mem2Reg for store_borrows is straight forward now that I have fixed the store_borrow representation in SIL. |
meg-gupta
force-pushed
the
mem2regstoreborrowpr
branch
2 times, most recently
from
5786abb to
8c9c61a
Compare
|
@swift-ci test |
meg-gupta
force-pushed
the
mem2regstoreborrowpr
branch
from
8c9c61a to
ed7788f
Compare
|
@swift-ci test and merge |
|
@swift-ci test macOS Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.