Skip to content

[refactoring] Run refactoring tests on Linux #59599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 21, 2022

Refactoring tests have been disabled on Linux but I can’t find a reason why that should be the case. Enable them on all platforms.

rdar://92982631

Refactoring tests have been disabled on Linux but I can’t find a reason why that should be the case. Enable them on all platforms.

rdar://92982631
@ahoppen
Copy link
Member Author

ahoppen commented Jun 21, 2022

@swift-ci Please smoke test Linux

@ahoppen
Copy link
Member Author

ahoppen commented Jun 21, 2022

@swift-ci Please smoke test Windows

This fixes a test execution failure on Windows where the `refactor-check-compiles.py` is not an executable.
@ahoppen
Copy link
Member Author

ahoppen commented Jun 22, 2022

@swift-ci Please smoke test

@ahoppen ahoppen requested review from rintaro and akyrtzi June 22, 2022 15:46
@ahoppen
Copy link
Member Author

ahoppen commented Jun 22, 2022

@akyrtzi Do you remember why the refactoring tests weren’t run on platforms other than macOS before?

@akyrtzi
Copy link
Contributor

akyrtzi commented Jun 22, 2022

@akyrtzi Do you remember why the refactoring tests weren’t run on platforms other than macOS before?

I don't remember..

@ahoppen ahoppen merged commit 41cbca6 into swiftlang:main Jun 23, 2022
@ahoppen ahoppen deleted the pr/run-refactoring-test-linux branch July 20, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants