Skip to content

[Distributed] Unlock test which was ASAN failures in the past #59627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Jun 22, 2022

This was very very likely solved by our ID/ActorSystem property ordering, this would have indeed triggered ASAN.

Resolves rdar://92277271

@ktoso
Copy link
Contributor Author

ktoso commented Jun 22, 2022

@swift-ci please asan test

@ktoso
Copy link
Contributor Author

ktoso commented Jun 22, 2022

@swift-ci Please ASAN test

@ktoso
Copy link
Contributor Author

ktoso commented Jun 22, 2022

ASAN not triggering hm :-\

@ktoso
Copy link
Contributor Author

ktoso commented Jun 22, 2022

@swift-ci please test

@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Jun 22, 2022
@shahmishal
Copy link
Member

preset=buildbot_incremental_asan,tools=RDA,stdlib=RDA
@swift-ci Please test with preset macOS platform

@ktoso ktoso merged commit 5b899e5 into main Jun 23, 2022
@ktoso ktoso deleted the wip-asan-ok branch June 23, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants