Skip to content

[5.7][stdlib] use @_transparent in an appropriate spot #59645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

glessard
Copy link
Contributor

This is is a cherry-pick of #59327 to the 5.7 branch.

One of the equality operator definitions on Optional was inconsistently @inlinable, while its peers are @_transparent. As a consequence, the detailed diagnostics surrounding Optional with == and != differ strangely based on minute details. @_transparent makes more sense than @inline(__always) in the specific case of == and Optional.

Resolves rdar://95690105

@glessard glessard requested a review from a team as a code owner June 22, 2022 14:52
@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard glessard added r5.7 standard library Area: Standard library umbrella labels Jun 24, 2022
@glessard glessard requested a review from stephentyrone June 24, 2022 17:53
@glessard glessard merged commit f4d4899 into swiftlang:release/5.7 Jun 27, 2022
@glessard glessard deleted the rdar95690105-clone-of-46444561-for-5.7 branch June 27, 2022 20:48
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks standard library Area: Standard library umbrella swift 5.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants