Skip to content

[stdlib] Prototype bidirectional UTF-8 Decoding #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2016
Merged

[stdlib] Prototype bidirectional UTF-8 Decoding #5965

merged 2 commits into from
Dec 1, 2016

Conversation

dabrahams
Copy link
Contributor

statemachines

@dabrahams dabrahams force-pushed the utf8-bidirectional-decoding branch from 432aca8 to 6e5127e Compare November 28, 2016 21:36
@dabrahams
Copy link
Contributor Author

@swift-ci Please smoke test and merge

2 similar comments
@shahmishal
Copy link
Member

@swift-ci Please smoke test and merge

@dabrahams
Copy link
Contributor Author

@swift-ci Please smoke test and merge

jrose-apple
jrose-apple reviewed Nov 29, 2016
View reviewed changes
test/Prototypes/UTF8.swift
@@ -9,9 +9,12 @@
// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
// RUN: %target-run-simple-swift
// RUN: %target-build-swift -parse-stdlib -Xfrontend -disable-access-control %s -o %t/a.out
Copy link
Contributor

@jrose-apple jrose-apple Nov 29, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need -disable-access-control? Because it won't work in general for execution tests, or generally anything that needs linking.

@dabrahams
Copy link
Contributor Author

dabrahams commented Nov 30, 2016 via email

@jckarter
Copy link
Contributor

You can avoid the problem by not using @inline(__always) for the nested functions inside UTF8.parseForward, or else making UTF8.Classification.init public. It looks like we mark @inline(__always) functions as "fragile" to export their SIL even when they're private or nested, which seems unnecessary.

[stdlib] Bidirectional UTF-8 Prototype: tweaks/cleanups
497d481 
Some small optimizations and reorganization.
@dabrahams dabrahams force-pushed the utf8-bidirectional-decoding branch from e9e8d6a to 497d481 Compare November 30, 2016 23:59
@dabrahams
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 2840248 into master Dec 1, 2016
@dabrahams
Copy link
Contributor Author

@airspeedswift

@jrose-apple
Copy link
Contributor

Can you move this test to validation-test? StdlibUnicodeUnittest isn't built when just running the normal tests.

@gparker42 gparker42 mentioned this pull request Dec 1, 2016
Merged
@gparker42
Copy link
Contributor

This test is failing on iOS. Reverting in #6010.

@dabrahams
Copy link
Contributor Author

dabrahams commented Dec 1, 2016 via email

@gparker42
Copy link
Contributor

…and macOS:
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RD_test-simulator/2433/

Might be an intermittent failure.

@jrose-apple jrose-apple deleted the utf8-bidirectional-decoding branch December 1, 2016 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dabrahams @shahmishal @jckarter @jrose-apple @gparker42 @swift-ci