[test] Fix test that's failing on the Android CI since string processing was enabled by default #59650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing was enabled by default Also, move the test to test/Frontend/ where it belongs and disable implicit concurrency import too.
compnerd
approved these changes
Jun 22, 2022
|
@swift-ci please smoke test |
|
Mac CI failure is unrelated. |
|
@swift-ci please smoke test macOS platform |
|
Same Mac failure, looks like the macOS CI has been broken for a day. |
|
Ping, Mac CI is working now, I think we can get this in. |
|
@swift-ci please smoke test macOS platform |
|
@egorzhdan, would you merge? |
CodaFi
pushed a commit
to CodaFi/swift
that referenced
this pull request
Jun 28, 2022
[test] Fix test that's failing on the Android CI since string processing was enabled by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, move the test to test/Frontend/ where it belongs and disable implicit concurrency import too.
@compnerd, you added this to the Driver tests three years ago in #25902, but
%swiftonly invokes the frontend now (maybe it worked differently back then?) so I moved the test.@drodriguez, this should get the Android CI green again.
I have no idea why this only started failing on the Android CI, but not on the linux CI too.