[CMake] Check if a cmake variable 'SWIFT_INSTALL_EXCLUDE_[component]' is set for a component #5967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is set for a component. In which case the 'SWIFT_INSTALL_[component]' will be FALSE. This is useful to get the behavior where all components are set to install by default and exclude just a specific one.
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test OS X platform |
jrose-apple
reviewed
Nov 29, 2016
| @@ -85,7 +85,12 @@ macro(swift_configure_components) | |||
|
|
|||
| string(TOUPPER "${component}" var_name_piece) | |||
| string(REPLACE "-" "_" var_name_piece "${var_name_piece}") | |||
| set(SWIFT_INSTALL_${var_name_piece} TRUE) | |||
| if("${SWIFT_INSTALL_EXCLUDE_${var_name_piece}}" STREQUAL "") | |||
There was a problem hiding this comment.
This first part should be unneccessary; CMake already treats unset or empty variables as false.
There was a problem hiding this comment.
Thanks for the feedback, see #5985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if a cmake variable 'SWIFT_INSTALL_EXCLUDE_[component]' is set for a component.
In which case the 'SWIFT_INSTALL_[component]' will be FALSE.
This is useful to get the behavior where all components are set to install by default and exclude just a specific one.